Warn when PCM car disengages unexpectedly

commaai / opendbc

a Python API for your car

MIT License

1.98k stars 1.17k forks source link

Warn when PCM car disengages unexpectedly #1172

Open Chaheeto opened 2 years ago

Chaheeto commented 2 years ago

Describe the bug

"Take Control Immediately" alert doesn't display when the stock ACC disengages automatically on traction control or wheel slip detection.

What hardware does this issue affect?

comma three

Provide a route where the issue occurs

72c8dc9054796c61|2022-01-17--06-14-03--32

openpilot version

0.8.12

Additional info

Toyota Prius Prime, 2019.

adeebshihadeh commented 2 years ago

This is the case for all pcmCruise cars right now. Perhaps we should switch to button enable everything on the openpilot side.

pd0wm commented 2 years ago

As far as I'm aware most Toyota's don't broadcast any button state on CAN. We have to find the signal that indicates this disengagements and alert on them.

adeebshihadeh commented 2 years ago

commaai/openpilot#24721

j0dan commented 1 year ago

So is the issue that the Toyota is disengaging and OP has no way of knowing why?

It feels like a serious safety issue. Having your vehicle start drifting out of lane while driving is a bit freaky.