Closed tcoopman closed 4 years ago
I'm not sure why this PR also includes e9e9492
. I thought I started from master correctly.
Yes, it looks like you are on the right track.
@slashdotdash I think the functionality is complete, so ready for review.
Thanks @tcoopman, sorry for the delay in merging your PR.
This feature is needed to fix: https://github.com/commanded/commanded/issues/401
TODO
subscribe
from adisconnected
statecheckpoint_last_seen
ornotify_subscribers
probably needs to be changed as wellI guess a
transient
subscription can never get in adisconnected
state, because theAdvisoryLocks
are only used for saved subscriptions.In theory
checkpoint_last_seen
doesn't need to be changed, because the update statement will not fail, but changed it as well so we don't even try to update.To discuss
Because we don't store anything, it's possible to:
I think this is logical, but it might surprise some users, so I'll add it to the documentation.