search

commanded / eventstore

Event store using PostgreSQL for persistence
MIT License
1.05k stars 146 forks source link

Remove unmaintained elixir_uuid dependency #253

Closed dvic closed 2 years ago

dvic commented 2 years ago

The elixir_uuid dependency is unmaintained for a while now and it gives compile warnings with recent Elixir versions. I've basically replaced it with a vendored implementation borrowed from Ecto.

dvic commented 2 years ago

Oh and I bumped Elixir to 1.10 to get rid of the warning of using get_env inside a module body (instead of compile_env).

slashdotdash commented 2 years ago

Thanks for the pull request @dvic. The UUID library has also caused a lot of debate in the Commanded library. I’m ok with copying an implementation and having it referenced internally. It would be a smaller change to add an alias to the modules that use the UUID module rather, than prefixing each usage. Does that make sense?

dvic commented 2 years ago

Done :) I also renamed the function to match the old API.

slashdotdash commented 2 years ago

Thanks for the pull request Damir.