commercetools / commercetools-paypal-plus-integration

Integration between commercetools API and PayPal Plus API
Apache License 2.0
7 stars 1 forks source link

#120: remove bashisms #121

Closed andrii-kovalenko-ct closed 6 years ago

andrii-kovalenko-ct commented 6 years ago

make encrypt/decrypt scripts POSIX compatible. I encountered this problem when i tried to run the app on Linux with default dash shell - it won't work properly.

see more in https://wiki.ubuntu.com/DashAsBinSh

andrii-kovalenko-ct commented 6 years ago

@lojzatran in your example - nothing. But it might be different based on some cases: https://stackoverflow.com/questions/8748831/when-do-we-need-curly-braces-around-shell-variables

In current PR problem was not in {}, but rather in array values access BASH_SOURCE[0], which is not supported in POSIX standard^ https://stackoverflow.com/a/29835459/907576