search

commitizen / cz-jira-smart-commit

A commitizen adapter for Jira Smart Commits
https://confluence.atlassian.com/display/FISHEYE/Using+smart+commits
114 stars 48 forks source link

Add a commit message prompt #2

Closed janecakemaster closed 8 years ago

janecakemaster commented 8 years ago

Problem

While I was using this I realized that the commit messages generated don't have an actual commit message besides the smart hooks for JIRA. this way when you look at commits on GitHub you just see issue numbers and no message about what's actually in the commit

Solution

This PR moves the message prompt to beginning and makes it required. That message is now used to generate the beginning of the commit message.

Major changes

jimthedev commented 8 years ago

@kentcdodds does this github functionality break bitbucket functionality. I'm a bit unclear on Github/Jira vs. bitbucket/Jira functionality.

Also @janecakemaster, thanks so much for this PR! This is awesome. Before I merge, can you make sure to rebase to squash your commits. Thanks!

kentcdodds commented 8 years ago

I'm sure it's fine. I don't use this anymore, so I can't really test it.

jimthedev commented 8 years ago

Cool, thanks! On Fri, Jan 22, 2016 at 10:01 PM Kent C. Dodds notifications@github.com wrote:

I'm sure it's fine. I don't use this anymore, so I can't really test it.

— Reply to this email directly or view it on GitHub https://github.com/commitizen/cz-jira-smart-commit/pull/2#issuecomment-174126975 .

janecakemaster commented 8 years ago

rebased commits!