Closed tom-tan closed 1 month ago
Attention: Patch coverage is 85.48387%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 83.05%. Comparing base (
9a92ffc
) to head (d23f263
). Report is 8 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
schema_salad/dlang_codegen.py | 85.48% | 4 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Done! I confirmed that the D parser generated from the latest schemas for CWL v1.0, v1.1 and v1.2, and schema-salad-d (HEAD) can parse whole CWL documents listed in cwl-d-auto.
I will do some tweaks to make CI passed.
Now ready to merge!
Thanks!
This request contains the following improvements to dlang codegen.
[Implemented] Support extension objects in arrays
The current dlang code-generated parser rejects the extension objects such as
cwltool:CUDARequirement
in therequirement
field. This request is to accept such extension objects in parser level.Note: Extension fields such as
https://schema.org/name
as explained in the user guide are already supported in schema-salad-d level without changing dlang codegen.[Implemented] Support the
default
fieldThe current dlang codegen ignores the
default
field. Therefore schema-salad-d cannot generate the code to set the default value from the declaration. This request is to fix this issue by adding the@defalultValue
attribute to the generated field declarations.[Implemented] Support MapSchema
[Implemented] Support UnionSchema