search

compact / angular-bootstrap-lightbox

An AngularJS lightbox built using UI Bootstrap Modal.
http://compact.github.io/angular-bootstrap-lightbox/
MIT License
306 stars 134 forks source link

NPM install is missing index.js #52

Closed Karel-TOPdesk closed 6 years ago

Karel-TOPdesk commented 8 years ago

When installing via NPM the index.js is missing. #41

And something else: (I'm rather new with webpack so maybe this is just a mistake on my end.) Shouldn't the index.js file require the css file? like so:

require("./dist/angular-bootstrap-lightbox.css");
require('./dist/angular-bootstrap-lightbox');
module.exports = 'angular-bootstrap-lightbox';

Because without this the css doesn't emerge.

tylercd100 commented 8 years ago

@compact Is it possible to bump the version from 0.10.0 to 0.10.1 to fix this issue?

compact commented 8 years ago

Bumped to 0.11.0, sorry for the wait.

I don't know if the stylesheet should be required, because it'd break if someone isn't using a css loader. Should that be assumed?