search

comparable / My-Twitter-App

0 stars 0 forks source link

[Android Bootcamp] Twitter App client #1

Open comparable opened 11 years ago

comparable commented 11 years ago

Please review my app. /cc @nesquena I'll work on persistent and formatting and getting relative time part.

Thanks a lot! Joohee

nesquena commented 11 years ago

Ok for relative time check out https://gist.github.com/nesquena/58beb9c9fb324a6c8a04 Tip #7 for more details.

Nathan Esquenazi

On Tuesday, October 22, 2013 at 1:18 AM, Joohee Yoo wrote:

Please review my app. /cc @nesquena (https://github.com/nesquena)
I'll work on persistent and formatting and getting relative time part.
Thanks a lot! Joohee

— Reply to this email directly or view it on GitHub (https://github.com/comparable/My-Twitter-App/issues/1).

nesquena commented 11 years ago

Joohee, :+1: nice work overall. A few notes after checking out the code:

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

comparable commented 11 years ago

Thanks for the review.

and I have a question about the persistence, I have implemented with activeAndroid but I don't see anything under data folder in DDMS window.

Same thing happens with simple one activity, but I do see the saved text comes back when I restart the app. Can it be stored in different location? I'm using my phone.

On Tue, Oct 22, 2013 at 11:22 PM, Nathan Esquenazi <notifications@github.com

wrote:

Joohee, [image: :+1:] nice work overall. A few notes after checking out the code:

  • Good that you only have a single method which calls getHomeTimeline
  • Nice job adding ActiveAndroid annotations to the models
  • Consider adding the character count for Compose Activity to limit to
  • See this event handlerhttps://github.com/thecodepath/android_guides/wiki/Basic-Event-Listeners#textchangedlistenerfor more details. Here's a detailed Project 3 Feedback Guide herehttps://gist.github.com/nesquena/a41220c54c9550f69599which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
    • Good to see you added the tweet after you posted new on compose

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

— Reply to this email directly or view it on GitHubhttps://github.com/comparable/My-Twitter-App/issues/1#issuecomment-26882994 .

Joohee