search

component-driven / cypress-axe

Test accessibility with axe-core in Cypress
MIT License
622 stars 86 forks source link

update to support Cypress 7 #96

Closed Pomax closed 3 years ago

Pomax commented 3 years ago

Cypress is on 7.2.0 by now, it would be very useful if this package could be updated to support that (it's currently set to ^6)

Develliot commented 3 years ago

+1 this we now at cypress 7.3

mathiashellsing commented 3 years ago

cypress@7.4.0 now

rkristelijn commented 3 years ago

We have cypress@7.2 installed, seems to work most of the time however we get this error in the after each hook:

TypeError: Cannot read property 'level' of undefined

The only things I can find in the code of cypress itself is log.level. Just wondering if someone ran into the same issue

Edit: Cypress 6.9.1 gives the same error, so probably this is not related.

Pomax commented 3 years ago

that sounds like a separate issue and probably deserves getting filed as new issue - this one's specifically about updating the dependency entry to explicitly cover 7.x

rkristelijn commented 3 years ago

@Pomax thanks for the feedback, I'm unable to reproduce on an empty boilerplate https://github.com/rkristelijn/cypress-7-axe

Cypress-axe seem to work ok-ish with imports directly in the test file. Went ahead and added a simple pipeline to showcase, but it seems to error in the github actions context. Works locally though without problems

ben-reitz commented 3 years ago

Hey @rkristelijn - our application tests have been facing the same problem. It's only intermittent for us for some reason. Might be worth raising a separate issue for it. We were seeing it with cypress v6 too, although it seems to happen much more frequently with v7 🤷🏼