search

componentjs / package.js

Deprecated
https://github.com/component/guide/blob/master/component/repositories.md
7 stars 2 forks source link

Restore superagent #2

Open dominicbarnes opened 10 years ago

dominicbarnes commented 10 years ago

I'm creating this issue so I can start pushing for superagent to be restored.

@visionmedia I don't know what the exact problem was, could you share more details? I can't seem to find a precise answer in either the superagent or component issue tracker or commit history.

I'm willing to take a crack at this myself if I can understand and reproduce the problem.

jonathanong commented 10 years ago

I'm working on a generator branch i've unfortunately named cp https://github.com/component/package.js/tree/cp

https://github.com/cojs/cogent

superagent is pretty broken right now and doesn't support generators, and cogent is way simpler for what we need. (btw help with auth and proxy would be nice since i'm not too sure how those work)

dominicbarnes commented 10 years ago

Superagent is broken? Sad day :(

jonathanong commented 10 years ago

you can try fixing it, but i haven't seen any activity lately

dominicbarnes commented 10 years ago

My preference, at least for the time-being, is to work on getting superagent working for component again.

Unless @visionmedia has more to say about the state of superagent, of course.

jonathanong commented 10 years ago

everyone's preference is to get super agent fixed, but to me, it's easier to write a new lib properly in generators than to fix it for all use cases. we're talking about 1500 LOC vs. 100.

i also have the sense that @visionmedia 's attitude is "let's give up" like https://github.com/visionmedia/superagent/issues/249, which is pretty important for this lib.

i know one of it's main problems is that it doesn't support streams2. you can try upgrading it to streams2 and make it a duplex stream: https://github.com/isaacs/http-duplex-client. however, it's a pain in the ass to get all cases correctly like continue events. easier to use http or https directly.

tj commented 10 years ago

request libs get too big and unwieldy, features step on each other, it would be nice to have something more modular on top of the regular stuff, but yeah streams are just absolutely retarded so I'd rather just move .pipe() from superagent and do .on('response', and pipe that