search

computational-metabolomics / mspurity-galaxy

Galaxy tools for msPurity package: includes precursor ion purity calculations and spectral matching
GNU General Public License v3.0
3 stars 6 forks source link

v1.12.2+galaxy3 - fix reference to offsets in conditional #41

Closed bernt-matthias closed 4 years ago

Tomnl commented 4 years ago

Thanks for spotting this

bernt-matthias commented 4 years ago

Is this autoatically pushed to the toolshed?

If not you may consider to switch to IUC style github actions. Should be as simple as to

Then yoy have quite a bit of linting, weekly CI, and automatic deployment in the TTS and TS

bernt-matthias commented 4 years ago

This still needs an upload to the toolshed.

If you like you we can automatize this like so https://github.com/computational-metabolomics/cfm-galaxy/pull/6. But ideally you would want to have a single tool repo. Alternatively your tools could also go to a central repo like W4M .. but I guess this is no option.

Tomnl commented 4 years ago

Hi both,

Sorry forgot to push this to the toolshed. The fixed tool should be available now to download directly via the toolshed.

@bernt-matthias - I agree, it would be better to automate this - can I just copy the relevant section from cfm-galaxy repo? (I did something similar a while ago for some other tools but the approach looks a bit different now)

Also, eventually a central location for the tools might make sense at least for the computational-metabolomics tools - something @RJMW and I should consider (but not really an option at the moment).

bernt-matthias commented 4 years ago

can I just copy the relevant section from cfm-galaxy repo?

You can just copy the complete workflows.

You also need to setup the API keys for the TTS and the TS as github secrets.