search

con / opfvta-reexecution

Container-based Replication of https://doi.org/10.1038/s41398-022-01812-5
Apache License 2.0
1 stars 1 forks source link

build container automatically #24

Closed yarikoptic closed 11 months ago

yarikoptic commented 1 year ago

my summary from matrix chat in the light of finding of a reason for #21: outdated image

Ideally it should be made/pushed automatically by a CI job in that repo upon modification of that recipe to avoid such issues have a look e.g. at https://github.com/nipy/heudiconv/blob/master/.github/workflows/docker.yml workflow just constrain to build only when that Containerfile modifies also in that Containerfile adopt best practice from neurodocker -- put all apt lines to one line and then clean up after yourself e.g. see here https://github.com/ReproNim/reproin/blob/master/Dockerfile#L16 add this "lesson" (containers get outdated -- need to be automated) to the paper as one of the lessons learned

TheChymera commented 1 year ago

@yarikoptic is this not outdated? if not, could you detail it more? Not sure I understand exactly what's missing.

yarikoptic commented 1 year ago

we have https://hub.docker.com/orgs/centerforopenneuroscience/ but so far I failed to "bind" a service user to this org to autotrigger updates.

TheChymera commented 11 months ago

@yarikoptic now that we're finally wrapping up, should we deal with this or close it?

yarikoptic commented 11 months ago

since not done, let's do wontfix