search

conan-io / examples

Conan 1.x examples
MIT License
124 stars 66 forks source link

Split package ID from build order JSON #35

Closed danimtb closed 5 years ago

danimtb commented 5 years ago

In Conan 1.18.5 the JSON file generated for the build order was containing the recipe revision. The build script was taking only the reference by splitting the value with #.

In Conan 1.19 this was fixed and the build order only has the reference and the package ID, so the split should be changed to correctly use :.

danimtb commented 5 years ago

This could be a Bug in Conan 1.19. We are investigating

danimtb commented 5 years ago

The change in the Conan code shipped in 1,19 was done in this PR https://github.com/conan-io/conan/pull/5412 and there was a discussion about the offending change here: https://github.com/conan-io/conan/pull/5800/files#r328973730

I think @memsharded wanted to remove only the PREV, not the RREV as well. However, PackageReference::copy_clear_rev() clears both the PREV and the RREV.

danimtb commented 5 years ago

I have opened a PR in Conan with a fix for this https://github.com/conan-io/conan/pull/5863. If the bug is confirmed and that PR merged, then whe should discard this one.

danimtb commented 5 years ago

Finally closing this PR in favor of conan-io/conan#5863. We will check when Conan 1.19.2 is released if the example runs without issues