search

concordion / cubano

A packaged framework for implementing web and API test suites. Builds on Concordion to bring your software delivery team together around living documentation.
http://concordion.org/cubano/framework
Apache License 2.0
15 stars 2 forks source link

incrementBrowserTestCount() is called multiple times per test #70

Closed nigelcharman closed 6 years ago

nigelcharman commented 6 years ago

I'm just debugging cubano-demo and see that incrementBrowserTestCount() is called multiple times per test, since it is called from BasePageObject.getBrowser() which is invoked from BasePageObject.waitUntil(), eg. WebDriverWait wait = new WebDriverWait(getBrowser().getDriver(), timeOutInSeconds);

This would cause the browser to be recreated often if the config property browserCloseAfterXTests was set to >0.

nigelcharman commented 6 years ago

Oops, looks like this is handled by the browserTestRunCounted flag. I'm closing this issue.