search

concordion / cubano

A packaged framework for implementing web and API test suites. Builds on Concordion to bring your software delivery team together around living documentation.
http://concordion.org/cubano/framework
Apache License 2.0
15 stars 2 forks source link

Use ReportLogger rather than Logger #82

Open nigelcharman opened 6 years ago

nigelcharman commented 6 years ago

Email from @andrew-sumner:

ReportLogger should be moved from CubanoDemoFixture to ConcordionBase and replace Logger. Should it have a getter as instead of being a protected field?

nigelcharman commented 6 years ago

My response:

Using a protected field is a fairly common practice.

A method would allow you to change the implementation, assuming Logger was an interface - eg. you wanted to return a different subclass, or a logger with a name different from the class name, based on some context that was passed in to the getLogger method?

I'm tempted to leave as a protected field, unless you think we might want different implementations to be returned?