search

concordion / cubano

A packaged framework for implementing web and API test suites. Builds on Concordion to bring your software delivery team together around living documentation.
http://concordion.org/cubano/framework
Apache License 2.0
15 stars 2 forks source link

Fix for last commit to ActionWait so that both withTimeout and #98

Closed andrew-sumner closed 5 years ago

andrew-sumner commented 5 years ago

withMaxAttempts work correctly - and add some tests to prove it.

andrew-sumner commented 5 years ago

@nigelcharman I think I've addressed all your comments, and I've added some more tests in to improve the coverage. These tests required some small improvements to the ActionWait class when dealing with millisecond level waits - which is not what this class was designed for but good to fix.

nigelcharman commented 5 years ago

Will need a merge of master please @andrew-sumner