search

concourse / concourse-bosh-deployment

A toolchain for deploying Concourse with BOSH.
Apache License 2.0
86 stars 155 forks source link

Changed instance groups update mechanism to serial #187

Closed alexbakar closed 4 years ago

alexbakar commented 5 years ago

Signed-off-by: Alexander Bakardzhiev alexander.bakardzhiev@sap.com

Related to https://github.com/concourse/concourse-bosh-release/issues/44 If the instance groups are updated in parallel, race conditions between the (instance group of) web nodes and (instance group of) worker nodes may happen, for example as with the case of long-running draining mentioned in the above issue. Making the instance groups update serial would avoid such race conditions. *Note that this change won't affect how the instances in the instance groups are updated (they can still be updated in parallel as "max_in_flight" is set to 3.

vito commented 4 years ago

Going to close this out since it seems inactive, but happy to re-review later. Sorry again for the slow response.Going to close this out since it seems inactive, but happy to re-review later. Sorry again for the slow response.