concourse / concourse-bosh-deployment

A toolchain for deploying Concourse with BOSH.
Apache License 2.0
86 stars 155 forks source link

Datadog hostname might be configured incorrectly #194

Open deniseyu opened 4 years ago

deniseyu commented 4 years ago

In our Datadog agent ops file we enable the unique_friendly_hostname flag.

But according to the Datadog bosh release, that flag only matters if the friendly_hostname flag is also set to true:

<%
  # Force the hostname to whatever you want. (default: auto-detected)
  # if no hostname is specified, it will just use the name of the VM
  if p("dd.hostname", nil)
    hostname = p("dd.hostname", "")
  elsif p("dd.use_uuid_hostname", false) and spec.id and not spec.id.empty?
    hostname = spec.id
  elsif p("dd.friendly_hostname", true)
    hostname = "#{spec.name.tr('_', '-')}-#{spec.index}"
    if p("dd.unique_friendly_hostname", false)
      hostname = "#{hostname}-#{spec.deployment}"
    end
  end
%>

so I think what's happening now is we're just using the hostname, since dd.hostname isn't defined. If we want to use unique_friendly_hostname we might also need to set friendly_hostname to true.