Parameterize azs in concourse manifest

concourse / concourse-bosh-deployment

A toolchain for deploying Concourse with BOSH.

Apache License 2.0

86 stars 155 forks source link

Parameterize azs in concourse manifest #91

Closed tyacovone closed 5 years ago

tyacovone commented 6 years ago

All instances should be bound to the same availability zone and this zone should be explicitly declared by the individual deploying the given Concourse instance.

Authored-by: Trevor Yacovone tyacovone@pivotal.io

FlorentFlament commented 5 years ago

Hi,

This PR relates to the following issue: https://github.com/concourse/concourse-bosh-deployment/issues/33

Is there any news regarding this ?

Regarding the commit itself, it would probably be clearer either way:

azs: [((availability_zone))] if we enforce a single availability zone
azs: ((availability_zones)) if we allow multiple availability zones

Regards, Florent

vito commented 5 years ago

@FlorentFlament Thanks for the reminder!

I think we should just close this and let folks use an ops file to override it (as suggested by https://github.com/concourse/concourse-bosh-deployment/issues/33#issuecomment-355092052). Making it a var would be backwards-incompatible and in common/simple cases folks probably won't care to specify other/multiple AZs.

Thanks all!