search

concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
143 stars 174 forks source link

feat: support labels on worker volumeClaimTemplate #333

Closed lrstanley closed 1 year ago

lrstanley commented 1 year ago

Existing Issue

This PR adds support for applying labels to the PVCs created by the worker's statefulset, via volumeClaimTemplates. In some backup regimes, items are included/excluded from backups by virtue of their labels.

Closes & replaces: https://github.com/concourse/concourse-chart/pull/322.

Why do we need this PR?

Changes proposed in this pull request

Contributor Checklist

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)
lrstanley commented 1 year ago

re: @xtremerui

Also, should the PR include a bump to the chart version, or is that done post-merge?

xtremerui commented 1 year ago

Thx for picking it up. Bump is done when publishing.

lrstanley commented 12 months ago

@xtremerui looks like a new release wasn't pushed. Would you be able to kick one off by chance?