conda-forge / dartsim-feedstock

A conda-smithy repository for dartsim.
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

MNT: rerender and enable windows tests #38

Closed conda-forge-admin closed 1 year ago

conda-forge-admin commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #37.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #37

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 1 year ago

Error:

[ 18%] Building CXX object dart/CMakeFiles/dart.dir/integration/EulerIntegrator.cpp.o
In file included from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/Core:294,
                 from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/Dense:1,
                 from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.hpp:36,
                 from /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp:33:
In constructor 'Eigen::PlainObjectBase<Derived>::PlainObjectBase(Eigen::PlainObjectBase<Derived>&&) [with Derived = Eigen::Matrix<double, 2, 1>]',
    inlined from 'Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>::Matrix(Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>&&) [with _Scalar = double; int _Rows = 2; int _Cols = 1; int _Options = 0; int _MaxRows = 2; int _MaxCols = 1]' at /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/src/Core/Matrix.h:274:30,
    inlined from 'Eigen::Vector2d dart::math::computeClosestPointOnSupportPolygon(std::size_t&, std::size_t&, const Eigen::Vector2d&, const SupportPolygon&)' at /home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp:2096:10:
/home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/eigen3/Eigen/src/Core/PlainObjectBase.h:496:9: error: '*(__m128d*)((char*)&result + offsetof(Eigen::Vector2d, Eigen::Matrix<double, 2, 1, 0, 2, 1>::<unnamed>.Eigen::PlainObjectBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::MatrixBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 3>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 1>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 0>::<unnamed>))' may be used uninitialized [-Werror=maybe-uninitialized]
  496 |       : m_storage( std::move(other.m_storage) )
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp: In function 'Eigen::Vector2d dart::math::computeClosestPointOnSupportPolygon(std::size_t&, std::size_t&, const Eigen::Vector2d&, const SupportPolygon&)':
/home/conda/feedstock_root/build_artifacts/dartsim_1684411846598/work/dart/math/Geometry.cpp:2079:25: note: '*(__m128d*)((char*)&result + offsetof(Eigen::Vector2d, Eigen::Matrix<double, 2, 1, 0, 2, 1>::<unnamed>.Eigen::PlainObjectBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::MatrixBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseBase<Eigen::Matrix<double, 2, 1, 0, 2, 1> >::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 3>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 1>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 0, 2, 1>, 0>::<unnamed>))' was declared here
 2079 |   Eigen::Vector2d test, result;
      |                         ^~~~~~
cc1plus: all warnings being treated as errors

We need to disable warning as errors.

traversaro commented 1 year ago

Windows fails:

%PREFIX%\Library\include\eigen3\Eigen\src/Core/DenseBase.h(43): fatal error C1060: compiler is out of heap space

we probably need again to reduce the number of threads.

traversaro commented 1 year ago

It just fails test_Collision on Windows, I think we can suppress the test and proceed.

traversaro commented 1 year ago

It just fails test_Collision on Windows, I think we can suppress the test and proceed.

Apparently test_Collision is already supressed in Linux/macOS : https://github.com/conda-forge/dartsim-feedstock/blob/c765f62e877c61def00fdd47f99f8f319ad567f1/recipe/build.sh#LL35C33-L35C47 .