search

conda-forge / faiss-split-feedstock

A conda-smithy repository for faiss-split.
BSD 3-Clause "New" or "Revised" License
4 stars 15 forks source link

Add aarch64 support #45

Closed jjacobelli closed 2 years ago

jjacobelli commented 3 years ago

Add aarch64 support

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jjacobelli commented 3 years ago

@conda-forge-admin, please rerender

h-vetinari commented 3 years ago

This errors...

CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!

Note that 1.7.1 was recently released, and I'll need to revamp the build system a bit. I think it's still worth iterating on what you have in the PR here already, and then it should be quite straightforward to adapt for the new version.

Also, thanks for the PR! :)

jjacobelli commented 3 years ago

This errors...

CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!

Note that 1.7.1 was recently released, and I'll need to revamp the build system a bit. I think it's still worth iterating on what you have in the PR here already, and then it should be quite straightforward to adapt for the new version.

Also, thanks for the PR! :)

I think this should be fixed by adding make as build dependency on Linux

h-vetinari commented 3 years ago

I think this should be fixed by adding make as build dependency on Linux

Certainly not for all of linux, it works fine without on x86...

But do whatever you think is necessary; let me know when the aarch-CI turns green and I'll have a look.

jjacobelli commented 3 years ago

I think this should be fixed by adding make as build dependency on Linux

Certainly not for all of linux, it works fine without on x86...

But do whatever you think is necessary; let me know when the aarch-CI turns green and I'll have a look.

I think it's because the conda-forge/linux-anvil image provide make on x86_64 and not on aarch64:

$ docker run --rm quay.io/condaforge/linux-anvil which make
/usr/bin/make
docker run --rm quay.io/condaforge/linux-anvil-aarch64 which make
/usr/bin/which: no make in (/opt/conda/bin:/opt/conda/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/conda/bin)
h-vetinari commented 3 years ago

@Ethyling Yeah, that would have been my guess. Might want to fix this (or raise an issue) in https://github.com/conda-forge/docker-images.

OTOH, perhaps it's cleaner to just depend on the environment-make rather than the image-one...

h-vetinari commented 3 years ago

@conda-forge-admin, please rerender

h-vetinari commented 3 years ago

@Ethyling I finally got around to figuring out the problems in #46 and merging the builds for 1.7.1. I took the liberty of rebasing your onto master, would be happy to see this continue! 🙃

h-vetinari commented 3 years ago

Seems the test suite is hanging somewhere on aarch. I'm switching on artefact persistence so that someone with an aarch machine can dig into this. Probably needs upstream fixes.

jjacobelli commented 2 years ago

Close in favor of https://github.com/conda-forge/faiss-split-feedstock/pull/51