conda-forge / geos-feedstock

A conda-smithy repository for geos.
BSD 3-Clause "New" or "Revised" License
3 stars 16 forks source link

Rewrite build.sh to use CMake instead of autotools #60

Closed mwtoews closed 3 years ago

mwtoews commented 3 years ago

Checklist

Summary of changes

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

gillins commented 3 years ago

Hi @mwtoews . any chance this could change the symbols exported by the library? I worry this might break the ABI...

My feeling would be that it is safest to wait until a new version arrives (and we have to migrate dependent packages anyway). Unless there is some guarantee of ABI stability?

mwtoews commented 3 years ago

There are a few differences with the outputs from CMake vs. Autotools, see a related GEOS ticket #669. For instance, Autotools builds libgeos-3.9.1.so while CMake builds libgeos.so.3.9.1. The C API should remain stable, but there is never a guarantee for the C++ ABI stability.

I don't mind holding this PR as a draft until the next GEOS release.

gillins commented 3 years ago

I don't mind holding this PR as a draft until the next GEOS release.

That sounds like a good plan! I think we need to be pretty careful with this in case we break something. Any idea when a new release will be ready?

mwtoews commented 3 years ago

Not sure when next release is due, as it's not as regular as PROJ, but I follow the mail list so will see any announcement.

mwtoews commented 3 years ago

Will add commits from this PR into #61