Closed mwtoews closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi @mwtoews . any chance this could change the symbols exported by the library? I worry this might break the ABI...
My feeling would be that it is safest to wait until a new version arrives (and we have to migrate dependent packages anyway). Unless there is some guarantee of ABI stability?
There are a few differences with the outputs from CMake vs. Autotools, see a related GEOS ticket #669. For instance, Autotools builds libgeos-3.9.1.so
while CMake builds libgeos.so.3.9.1
. The C API should remain stable, but there is never a guarantee for the C++ ABI stability.
I don't mind holding this PR as a draft until the next GEOS release.
I don't mind holding this PR as a draft until the next GEOS release.
That sounds like a good plan! I think we need to be pretty careful with this in case we break something. Any idea when a new release will be ready?
Not sure when next release is due, as it's not as regular as PROJ, but I follow the mail list so will see any announcement.
Will add commits from this PR into #61
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Summary of changes
-V
, same as build.sh