conda-forge / graphblas-feedstock

A conda-smithy repository for graphblas.
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Arch Migrator #53

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3325621304, please use this URL for debugging.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

eriknw commented 1 year ago

Travis CI times out when building. @jakirkham, do you know if there's another way?

jakirkham commented 1 year ago

Could either do emulated builds or cross-compile. The former takes longer, but runs on Azure, which has a longer time limit. The latter also runs on Azure, but we can't run the tests then

jakirkham commented 1 year ago

Thoughts @eriknw?

eriknw commented 1 year ago

Thanks @jakirkham. I think the GraphBLAS recipe needs better tests. The osx_arm64 build we just added has some issues that we're looking into (but many things work). Maybe we could try to compile and run some of the Demos/ as tests?

I'm not worried about long CI time as long as the job finishes, so I think we should try emulated builds on Azure next. How do we do this? Is this page relevant https://conda-forge.org/docs/maintainer/infrastructure.html?

jakirkham commented 1 year ago

@conda-forge-admin, please re-render

jakirkham commented 1 year ago

There's not a great doc page for this info. Not one I can find anyway. Raised issue ( https://github.com/conda-forge/conda-forge.github.io/issues/1841 ) on improving this.

For now went ahead and just enabled emulated builds here. It is worth noting long time here could be ~6hrs. So we may still decide this is unacceptable. It is also possible the builds still don't complete when emulated (they go much slower).

If emulation doesn't work, would suggest we move to cross-compilation. Yes testing is limited, but the build times are much better. Plus the testing limitation doesn't apply to the x86_64 builds. So we should still get some testing (just not so much on the other architectures).

eriknw commented 1 year ago

Emulation timed out. Time to try cross-compilation?

jakirkham commented 1 year ago

@conda-forge-admin, please re-render

jakirkham commented 1 year ago

Yeah the timeout doesn't surprise me. Have reconfigured for cross-compilation. Let's see how it goes 🙂

jakirkham commented 1 year ago

Should add we only have file existence tests, which should work fine with cross-compilation

https://github.com/conda-forge/graphblas-feedstock/blob/677e6a9508fe4e97b8781e146eb79a0a1c1be7de/recipe/meta.yaml#L30-L34

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 1 year ago

Looks like that worked! 🎉

Packages should be uploaded soon 😄