Closed eriknw closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Thanks @eriknw. This looks good (pending CI success)
I am not certain if any downstream packages currently depend on the static library. I suppose we can remove it and if there are complaints, add a separate, static package later.
Shall we merge? Do we need to re-render first?
@conda-forge-admin, please rerender
Oh, I'm not a maintainer yet, so I don't know if I can initiate a rerender.
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Checklist
conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Let's not build the static library. See: https://github.com/conda-forge/cfep/blob/master/cfep-18.md
Also, let's tell cmake we're doing a "Release" build.
I received feedback to make these improvements for the LAGraph recipe here: https://github.com/conda-forge/staged-recipes/pull/12391