conda-forge / graphblas-feedstock

A conda-smithy repository for graphblas.
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

No static #9

Closed eriknw closed 4 years ago

eriknw commented 4 years ago

Checklist

Let's not build the static library. See: https://github.com/conda-forge/cfep/blob/master/cfep-18.md

Also, let's tell cmake we're doing a "Release" build.

I received feedback to make these improvements for the LAGraph recipe here: https://github.com/conda-forge/staged-recipes/pull/12391

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

grlee77 commented 4 years ago

Thanks @eriknw. This looks good (pending CI success)

I am not certain if any downstream packages currently depend on the static library. I suppose we can remove it and if there are complaints, add a separate, static package later.

eriknw commented 4 years ago

Sounds good. I believe grblas should be fine without the static library. Even if somebody needs the static library, it should be made available as graphblas-static. See here.

eriknw commented 4 years ago

Shall we merge? Do we need to re-render first?

@conda-forge-admin, please rerender

eriknw commented 4 years ago

Oh, I'm not a maintainer yet, so I don't know if I can initiate a rerender.

github-actions[bot] commented 4 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!