Bump version to 1.3.35 and enable Windows build.

seanyen commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Enabling Windows port.
Adding myself as co-maintainer.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

Hmm, it is surprised to see that Linux build failed. Hope someone on gitter can shed some lights. https://gitter.im/conda-forge/conda-forge.github.io?at=5e83f340c6e44255a1c930c1

Packaged license file/s.
Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 474, in main
    execute(sys.argv[1:])
  File "/opt/conda/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 465, in execute
    verify=args.verify, variants=args.variants)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/api.py", line 209, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/build.py", line 2868, in build_tree
    notest=notest,
  File "/opt/conda/lib/python3.7/site-packages/conda_build/build.py", line 2155, in build
    newly_built_packages = bundlers[pkg_type](output_d, m, env, stats)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/build.py", line 1522, in bundle_conda
    output['checksums'] = create_info_files(metadata, files, prefix=metadata.config.host_prefix)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/build.py", line 1199, in create_info_files
    write_info_files_file(m, files)
  File "/opt/conda/lib/python3.7/site-packages/conda_build/build.py", line 1044, in write_info_files_file
    fo.write(f + '\n')
UnicodeEncodeError: 'utf-8' codec can't encode characters in position 4-5: surrogates not allowed

seanyen commented 4 years ago

@conda-forge/graphicsmagick The Windows port is enabled. However I don't know why the Linux build is broken, honestly I didn't change the Linux recipe. Hope someone can shed some lights here.

wolfv commented 4 years ago

Hmm I am wondering if somehow some unicode character slipped into any of the files? It seems to fail when the info data is bundled (that data also consists of the meta.yaml file and the build script). The error says that characters from a certain unicode range are not allowed ... I checked briefly but couldn't spot anything out of the ordinary. Maybe there is some tool to check if there are e.g. invisible unicode characters?

seanyen commented 4 years ago

Got a Linux box and run the recipe. It turned out GraphicsMagick created some weird file with funny characters under $PREFIX\lib and make it a symlink to libxkbcommon.so. I don't know where GraphicsMagick generates the symlink but if there is no x11 packages in the deps, this problem will be gone so I try to restrict the x11 to osx only.

seanyen commented 4 years ago

@conda-forge/graphicsmagick This is ready for review and merge. Thanks.

seanyen commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

seanyen commented 4 years ago

@bgruening Hi! Friendly ping. Hope we can add Windows build too.

seanyen commented 4 years ago

cc @isuruf This is ready for review and merge. Hope we can add a Windows port for it.

seanyen commented 4 years ago

@conda-forge/staged-recipes @bgruening Friendly ping! Hope we can move forward with a Windows build.

isuruf commented 4 years ago

For the linux issue. You can delete that weird file at the end of build.sh.

seanyen commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

@conda-forge-admin, please rerender

seanyen commented 4 years ago

@conda-forge/core @conda-forge/graphicsmagick This is ready for review and merge. Thanks!

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

isuruf commented 4 years ago

Can you fix the warnings in conda-build?

seanyen commented 4 years ago

@isuruf Assuming you are talking about the overlinking and overdepending, they are fixed now.

seanyen commented 4 years ago

@isuruf Thanks for the feedback. Let me know if any additional things to fix.

seanyen commented 4 years ago

@conda-forge/core @conda-forge/graphicsmagick Sorry to spam again. This is ready for review and merge. Thanks!

conda-forge / graphicsmagick-feedstock

Bump version to 1.3.35 and enable Windows build. #8