conda-forge / gz-sim-feedstock

A conda-smithy repository for gz-sim.
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Backport relocatability fixes #19

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

As merging https://github.com/gazebosim/gz-sim/pull/1968 upstream is taking some time, let's backport the patch here. While this indeed introduces some new ABI symbols, if the symbols ends being changed in the upstream release, we can always re-introduce them with a custom patch, if that turns out to be necessary.

Similar to https://github.com/conda-forge/gz-physics-feedstock/pull/11 .

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gz-sim-feedstock/actions/runs/5321774113.

traversaro commented 1 year ago

Currently we also have the warning:

2023-06-20T11:32:05.3161857Z /home/conda/feedstock_root/build_artifacts/gz-sim7_1687259193132/work/src/systems/physics/Physics.cc:805:13: warning: 'GZ_PHYSICS_ENGINE_INSTALL_DIR' macro is deprecated, use gz::physics::getEngineInstallDir() function instead. 
2023-06-20T11:32:05.3162561Z   805 |   systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});
2023-06-20T11:32:05.3163187Z       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  

We should add a local patch for that.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!