conda-forge / intel_repack-feedstock

A conda-smithy repository for intel_repack.
BSD 3-Clause "New" or "Revised" License
6 stars 19 forks source link

Set default stdlib requirement to mkl #84

Closed ZzEeKkAa closed 1 week ago

ZzEeKkAa commented 1 week ago

Checklist

As mentioned by @h-vetinari at https://github.com/conda-forge/intel_repack-feedstock/pull/82/files/462540bf2bc86a600f7be112379d6def0ce68859#r1835172927 there was an error with setting correct glibc dependency

ZzEeKkAa commented 1 week ago

Thank you @h-vetinari for finding the issue. Could you please review this PR?

conda-forge-admin commented 1 week ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

oleksandr-pavlyk commented 1 week ago

Just making sure that change to replace - {{ c_stdlib }}_{{ target_platform }} >={{ c_stdlib_sycl_version }} # [linux] with - {{ c_stdlib }}_{{ target_platform }} {{ c_stdlib_sycl_version }} # [linux] was purely stylistic.

The real issue was that {{ c_stdlib_sycl_version }} was used in non-SYCL components, i.e., mkl.

ZzEeKkAa commented 1 week ago

Just making sure that change to replace - {{ c_stdlib }}_{{ target_platform }} >={{ c_stdlib_sycl_version }} # [linux] with - {{ c_stdlib }}_{{ target_platform }} {{ c_stdlib_sycl_version }} # [linux] was purely stylistic.

The real issue was that {{ c_stdlib_sycl_version }} was used in non-SYCL components, i.e., mkl.

Yes, exactly. I've checked that removing >= does not affect result glibc pinning