add run_exports - Githubissues

conda-forge / occt-feedstock

A conda-smithy repository for occt.

BSD 3-Clause "New" or "Revised" License

4 stars 21 forks source link

add run_exports #98

Closed matthiasdiener closed 1 year ago

matthiasdiener commented 1 year ago

See https://github.com/conda-forge/occt-feedstock/issues/97, https://github.com/conda-forge/gmsh-feedstock/pull/72 for context.

cc @isuruf @inducer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

matthiasdiener commented 1 year ago

A gentle ping for review @conda-forge/occt @isuruf

whophil commented 1 year ago

Does this mean that projects which list occt as a host dep will be automatically given a run dep of occt with a version strictness of x.x.x? If so, it would be great if we could get this merged. Thanks!

matthiasdiener commented 1 year ago

Does this mean that projects which list occt as a host dep will be automatically given a run dep of occt with a version strictness of x.x.x?

Yes, that is my understanding as well.

whophil commented 1 year ago

@looooo could we get this merged in?

Also a more general question, maybe for @isuruf - how does this interact with this pin_run_as_build in global pinning? https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml#L202-L203

matthiasdiener commented 1 year ago

@conda-forge-admin, please rerender