Closed regro-cf-autotick-bot closed 3 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
Yeah, I guess. I'm also not 100% sure this matters. If $LDFLAGS are respected in conda-forge packages, then --disable-new-dtags
will also be given after the enable embedded in the wrapper, so disable will have higher priority, I think. So anything built with mpicc in conda-forge still does not use new dtags, I think, even with this in the wrapper.
On a somewhat related matter, why are we setting wrapper_ldflags='-Wl,--allow-shlib-undefined'
in compiler wrappers? Isn't that flag something that conda-forge should add globally to LDFLAGS?
the shlib-undefined is related to user runtime compilation and conda-forge's weighed-down default sysroot to older than the one used to build openmpi (not technically the case anymore as of this month). Discussion is in #143 (especially here). Essentially, package compilation is expected to use $LDFLAGS, but I don't think user runtime compilation necessarily should. So the wrappers should include whatever flags are necessary for compilation to basically function, as opposed to doing the opinionated 'right thing' for building a conda-forge package, and allow-shlib-undefined
is required for mpicc to basically function by default in a default environment.
I don't believe preferring old sysroot for user environments is the right move, and hope it will stop happening soon after the c_stdlib migration completes, but for now allow-shlib-undefined
in the wrapper is a practical choice such that mpicc can work at all by default.
--allow-shlib-undefined
always works, while pinning sysroot adds unconditional extra work for downstream package maintainers if the default sysroot is older, because it actually does work fine (thanks to --allow-shlib-undefined
).@minrk All good then , please merge at your earliest convenience, then I can move to PETSc.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.