search

conda-forge / paprika-feedstock

A conda-smithy repository for paprika.
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

SHA256 problems on Azure #3

Open slochower opened 5 years ago

slochower commented 5 years ago

Issue: Hi @conda-forge/core,

I'm seeing an SHA256 mismatch on my Azure builds. I'm not sure where to start helping debugging this. The only change I made is bumping the version number of my package and I just re-forked the feedstock, so everything should be up to date. Can you point me in the right direction? Thanks!

[...]
Success
SHA256 mismatch: 'b423e994467b3004104e437389addb17d7e9b72553d130abff7e0bbf11bdc3aa' != '22a97f6362b6ef9aea9210bd811e2c713dc29158bb61d17af9568a052778cf49'
##[error]Bash exited with code '1'.
mariusvniekerk commented 5 years ago

So.... GitHub generated generated archives are not eternal. In practice this means that their shad expire every few months. If you want a non expirable Sha you have to use a github release or get a tarball from another source

isuruf commented 5 years ago

It's not that issue @mariusvniekerk. @slochower you need to update the SHA256 of the archive when you update the version.

slochower commented 5 years ago

Ah! My mistake. Updating momentarily! Thanks @mariusvniekerk @isuruf .

slochower commented 5 years ago

Okay, great. I'd like to merge the PR. Is there a special place I should mark that is is okay that tests are failing because they depend on stuff outside the conda-forge ecosystem?

mariusvniekerk commented 5 years ago

Ideally those things should probably be in the conda forge ecosystem. If they are not there then other users can't easily use this package.

slochower commented 5 years ago

Agreed & agreed. But their maintenance is unfortunately out of my control. We are working on it, though (for example)!

isuruf commented 5 years ago

Can you make those dependencies optional? i.e. package would have less features if those dependencies are not installed, but still work.

slochower commented 5 years ago

@isuruf not really, unfortunately. At least, not yet. This package sets up, runs, and analyzes simulations. Without the simulation code, it really wouldn't work at all (we can't even setup the simulations, because we need to know something about how the simulations work). But it looks like ambertools now has a working conda-forge package and hopefully openmm will be coming along shortly (held up due to figuring out how to deal with various CUDA installations, whether through conda or through NVIDIA).

mariusvniekerk commented 5 years ago

One thing you could do if you want to is to patch the conda-forge version of the package so that it warns users that this package needs additional dependencies and gives some degree of instruction on how to install them.

slochower commented 5 years ago

@mariusvniekerk interesting idea. How would I do that? Would I need to make separate releases on GitHub just for conda-forge then?

jakirkham commented 4 years ago

The openmm folks have added their package to conda-forge with GPU support. Figured you'd be happy to know that. 🙂

slochower commented 4 years ago

Oh, right, yes of course. I've been following the thread (about whether to include the OpenCL back end...) . Thanks for following up here, much appreciated. I will update this conda recipe soon.