conda-forge / r-base-feedstock

A conda-smithy repository for r-base.
BSD 3-Clause "New" or "Revised" License
14 stars 47 forks source link

unvendor tzdata #311

Closed isuruf closed 5 months ago

isuruf commented 5 months ago

Checklist

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mbargull commented 5 months ago

Would it be easy to add a test, e.g., to check whether data from >=2024a is used? (So we'd have a regression test from which we know it doesn't use the older zoneinfo from the container image.)

github-actions[bot] commented 5 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

github-actions[bot] commented 5 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

github-actions[bot] commented 5 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

mbargull commented 5 months ago

Windows logs have

installing 'sysdata.rda'
Warning messages:
1: unknown timezone 'Etc/UTC' 
2: unknown timezone 'GMT' 
3: unknown timezone 'America/New_York' 
4: unknown timezone 'GMT' 
5: unknown timezone 'America/New_York' 
building package 'compiler'
mv: preserving permissions for ‘all.R’: Not supported
Warning messages:
1: unknown timezone 'Etc/UTC' 
2: unknown timezone 'GMT' 
3: unknown timezone 'America/New_York' 
4: unknown timezone 'GMT' 
5: unknown timezone 'America/New_York' 
byte-compiling package 'compiler'
Warning messages:
1: unknown timezone 'Etc/UTC' 
2: unknown timezone 'GMT' 
3: unknown timezone 'America/New_York' 
4: unknown timezone 'GMT' 
5: unknown timezone 'America/New_York' 
byte-compiling package 'base'
Warning messages:
1: unknown timezone 'Etc/UTC' 
2: unknown timezone 'GMT' 
3: unknown timezone 'America/New_York' 
4: unknown timezone 'GMT' 
5: unknown timezone 'America/New_York' 
byte-compiling package 'tools'
building package 'utils'
mv: preserving permissions for ‘all.R’: Not supported
Warning messages:
1: In as.POSIXlt.POSIXct(x, tz) : unknown timezone 'Etc/UTC'
2: In as.POSIXlt.POSIXct(x, tz) : unknown timezone 'GMT'
3: In as.POSIXlt.POSIXct(x, tz) : unknown timezone 'America/New_York'
4: In as.POSIXlt.POSIXct(x, tz) : unknown timezone 'GMT'
5: In as.POSIXlt.POSIXct(x, tz) : unknown timezone 'America/New_York'
making init.d from init.c
isuruf commented 5 months ago

Hmm, that's because R is used without installing in the build script. We can set TZDIR temporarily to avoid those warnings.