search

conda-forge / r-devtools-feedstock

A conda-smithy repository for r-devtools.
BSD 3-Clause "New" or "Revised" License
3 stars 6 forks source link

Update r-devtools to 1.13.2. #1

Closed jdblischak closed 7 years ago

jdblischak commented 7 years ago

In addition to updating to the latest version of r-devtools, I also removed the dependency on a compiler. conda skeleton cran devtools does not include it, the recipe builds fine without it, and there was no discussion in the original PR to staged-recipes to indicate why it was needed.

My guess is that the compiler dependency was added because installing a compiler is recommended by r-devtools so that it can subsequently build R packages that contain code that needs to be compiled. If that is the case though, I would think that only the libgcc in run: would be needed since gcc is not needed to build r-devtools itself.

Please let me know if I should add back these dependencies.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jdblischak commented 7 years ago

@bgruening and @johanneskoester Please review when you get the chance

jdblischak commented 7 years ago

Actually now I am more confident about this change. The recent update in conda/conda-recipes from r-devtools 0.12.0 to 0.13.2 also removes these dependencies https://github.com/conda/conda-recipes/commit/76ae13ff9983d7978778ee382a160f562b474eb1

bgruening commented 7 years ago

@jdblischak I wonder whether this is just an error in the skeleton generator. The readme here states that a compiler need to be installed. On the other hand I can not see any C code in this repo. That the package does not fail is unfortunately no good indicator, as (at least the Linux) Docker container still has GCC installed.

jdblischak commented 7 years ago

I wonder whether this is just an error in the skeleton generator. The readme here states that a compiler need to be installed.

Right, but as I noted in my original message, is the compiler needs to build r-devtools itself or for r-devtools to be able to build other R packages that may contain C code?

On the other hand I can not see any C code in this repo. That the package does not fail is unfortunately no good indicator, as (at least the Linux) Docker container still has GCC installed.

At least one of its dependencies, r-git2r, has C code that needs to be compiled, but I assumed that conda can figure this out (i.e. we shouldn't have to recursively list all the dependencies in the top-level recipe).

bgruening commented 7 years ago

I don't know, I will dig a little bit deeper in the code tomorrow.

At least one of its dependencies, r-git2r, has C code that needs to be compiled, but I assumed that conda can figure this out (i.e. we shouldn't have to recursively list all the dependencies in the top-level recipe).

That is true.

bgruening commented 7 years ago

Ok, this seems to be save. Thanks a bunch!