conda-forge / sqlite-feedstock

A conda-smithy repository for sqlite.
BSD 3-Clause "New" or "Revised" License
2 stars 40 forks source link

Split gpl package #31

Closed hmaarrfk closed 6 years ago

hmaarrfk commented 6 years ago

Superseeds #30 (suggested using libedit instead) Fixes #29

Splits the package into a GPL'ed portion (the binary) and the non-gpl'ed portion (the library). See results from ldd.

(I didn't test it with windows or mac, lets see what the CI's say)

The binary is compiled with readline support, so it must have a GPLv3 license.

Notes from the discussion in #30 @bgruening suggested looking at how debian packages things

I am unfamiliar with debian packaging, but it doesn't seem that they list a license in their package.

They they split their package into an executable package and library.

Checklist

XREF: Issue on Continuum repo:

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

For recipe:

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

hmaarrfk commented 6 years ago

@conda-forge-admin please lint

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 6 years ago

@jakirkham @ocefpaf @scopatz @bgruening

Thank you for your comments on PR #30. I think this PR addresses all the issues and takes a step in the right direction in terms of compliance.

Depending on the feedback I receive from you guys I'll add a GPL license file for the sqlite3 executable.

hmaarrfk commented 6 years ago

@scopatz, hopefully I incorporated all the mods you requested.

The script is also much improved to ensure that we don't need to keep updating things. Let me know what you think.

hmaarrfk commented 6 years ago

Superseeded by https://github.com/conda-forge/staged-recipes/pull/6550