search

conda-forge / sqlite-feedstock

A conda-smithy repository for sqlite.
BSD 3-Clause "New" or "Revised" License
2 stars 40 forks source link

Update to 3.25.1... #38

Closed ocefpaf closed 6 years ago

ocefpaf commented 6 years ago

... And add SQLITE_ENABLE_GEOPOLY support.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mingwandroid commented 6 years ago

Libedit or readline are only used by the cli programs, so I don't think it's very important which is used here.

@jjhelmus had some preference (if it weren't for the licence issue) for readline but I don't know the details.

ocefpaf commented 6 years ago

Libedit or readline are only used by the cli programs, so I don't think it's very important which is used here. @jjhelmus had some preference (is it weren't for the licence issue)!for readline but I don't know the details.

Thanks for the info! I'll merge this one with readline and test libedit for sqlite in the future. Maybe the approach in #32 would make everybody happy when CLI is important.

mingwandroid commented 6 years ago

Beware that using readline in anything makes that thing GPL.

mingwandroid commented 6 years ago

So you can no longer state that sqlite is BSD.

mingwandroid commented 6 years ago

.. or anything it then links to.

mingwandroid commented 6 years ago

I feel on AD at least we have no choice but to remove all GPL dependencies from non-GPL software.

LGPL doesn't require this fortunately but readline is not LGPL.

ocefpaf commented 6 years ago

I feel on AD at least we have no choice but to remove all GPL dependencies from non-GPL software.

Sorry. Not sure what AD means there :smile: (Remember I'm an old guy and I don't know these cool acronyms young people like you use :stuck_out_tongue_winking_eye:)

Anyway, I believe we need a long term plan to address things like that. I'll bring that up in our next meeting.

mingwandroid commented 6 years ago

AD=Anaconda Distribution, trying to save my fingers.

ocefpaf commented 6 years ago

AD=Anaconda Distribution, trying to save my fingers.

Sorry to make you write more :grimacing: