search

conda-forge / vc-feedstock

A conda-smithy repository for vc.
BSD 3-Clause "New" or "Revised" License
4 stars 22 forks source link

New DLLs to copy for VS>=19.38; need to expand tests. #69

Closed h-vetinari closed 11 months ago

h-vetinari commented 1 year ago

When we activated VS2022, I double-checked if there were no new satellite libraries to the vcruntime.

Based on a recent blogpost about C11 threading support in Visual Studio, it appears that there will be two new DLLs (vcruntime140_threads.dll / vcruntime140_threadsd.dll) as of VS 17.8 that we'll have to include.

Or rather, they should get included by the repack mechanism and we'll just have to add tests for it, compare: https://github.com/conda-forge/vc-feedstock/blob/5cbd681a12658623d1c661dfe7b40a148d94d5eb/recipe/meta.yaml#L125-L135

where we could add something like:

        {% if vsyear == "2022" %}
        - if not exist %LIBRARY_BIN%\vcruntime140_threads.dll exit 1
        - if not exist %LIBRARY_BIN%\vcruntime140_threadsd.dll exit 1
        {% endif %}