conda-forge / vc-feedstock

A conda-smithy repository for vc.
BSD 3-Clause "New" or "Revised" License
4 stars 22 forks source link

Add 19.41 support #82

Closed isuruf closed 3 months ago

isuruf commented 3 months ago

Checklist

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

github-actions[bot] commented 3 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jdblischak commented 3 months ago

They briefly updated it ... and reverted it

@isuruf it looks like they've updated the image again. This morning my build was failing because it installed vs2022_win-64 19.41 in image version 20240811.1.0 (Visual Studio 17.10). Now that vs2022_win-64 19.41 has been marked as broken (https://github.com/conda-forge/admin-requests/pull/1056), I restarted the job, and it failed because it installed vs2022_win-64 19.40 in image version 20240825.1.0 (Visual Studio 17.11).

I always find these image updates hard to pinpoint since the actual update on Azure is unrelated to when the docs PR is merged (https://github.com/actions/runner-images/pull/10490 is still open).

xref: failing Azure build with changing image versions, https://github.com/TileDB-Inc/conda-forge-nightly-controller/issues/133#issuecomment-2313257891

isuruf commented 3 months ago

Mind sending a PR to mark them unbroken?

jdblischak commented 3 months ago

Sure. I'll do that now

jdblischak commented 3 months ago

This is chaos. Azure keeps switching the image version. Last night at 9:30 pm ET it was using 20240825.1.0 (Visual Studio 17.11), but then exactly 12 hours later this morning at 9:30 am ET, it reverting to using image version 20240811.1.0 (Visual Studio 17.10).

My questions are:

xref: https://github.com/TileDB-Inc/conda-forge-nightly-controller/issues/133#issuecomment-2315592291

jdblischak commented 3 months ago

Unfortunately it looks like we can't pin the exact image version for the Azure build, so that isn't an option as a short-term workaround https://github.com/actions/runner-images/discussions/3464