conda / constructor

tool for creating installers from conda packages
https://conda.github.io/constructor/
Other
457 stars 167 forks source link

RFC: Undoing constructor / conda-standalone cross "bundling" #549

Open jaimergp opened 2 years ago

jaimergp commented 2 years ago

constructor relies on a frozen version of conda named conda-standalone. conda-standalone is built off two feedstocks:

We will be syncing both to conda/conda-standalone soon.

conda-standalone is not just a frozen conda. It contains some modifications:

Patches:

Modified CLI:

_nsis.py comes from constructor! It's a helper script to aid Windows installers with some steps, like menu items creation.

Windows' NSIS installers end up using _nsis.py in two different ways:

The thing is that conda-standalone already features a FULL Python installation inside the frozen executable, so there's no need to force feed Python into the installer again.

My plan is to:

  1. Move the _nsis.py (and dependents) to conda/conda-standalone
  2. Replace the direct calls to _nsis.py with equivalent functionality through conda-standalone
  3. Do not require Python in the base environment anymore, but leave conda.exe in the installation, because it will be needed at uninstall time.
  4. (At some point) Package the constructor helpers in conda-standalone as a conda plugin, so building conda-standalone is less hacky

Thoughts, @conda/constructor?

cc @wolfv - since this might affect the micromamba integrations.

jezdez commented 2 years ago

Nice, this sounds like a great plan and should make things much more obvious.

github-actions[bot] commented 1 year ago

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

jaimergp commented 1 year ago

Still ongoing!