search

confidential-containers / operator

Operator to deploy confidential containers runtime
Apache License 2.0
102 stars 56 forks source link

CI: Use ubuntu-22.04 and not ubuntu-latest in workflows #348

Closed portersrc closed 4 months ago

portersrc commented 4 months ago

We should at least be consistent with the ubuntu base images we're running in the workflows. I also opt to use ubuntu-22.04 and not ubuntu-latest.

Other repos in the org can take a similar change if reviewers want.

wainersm commented 4 months ago

hi @BbolroC !

The s390x post-action step failed: https://github.com/confidential-containers/operator/actions/runs/7796965300/job/21262642550?pr=348

I wondering if there is something we can do to make that step more reliable.

stevenhorsman commented 4 months ago

hi @BbolroC !

The s390x post-action step failed: https://github.com/confidential-containers/operator/actions/runs/7796965300/job/21262642550?pr=348

I wondering if there is something we can do to make that step more reliable.

Choi might be able to confirm, but he updated and re-registered the s390x runners earlier, which might have coincided with that run?

I would re-queue, but it looks like we have an issue with getting az-ubuntu-2204 runners that I assume is related to the changes in this PR!

BbolroC commented 4 months ago

@wainersm @stevenhorsman yeah, the time matches. I was in the middle of the update at the time.

BbolroC commented 4 months ago

The test for s390x has been successfully passed. Sorry for the inconvenience.

GabyCT commented 4 months ago

lgtm