simple-kbs was originally developed internally. As such, a somewhat significant amount of code was available when the project was first moved to this repository. In order to continue active development without waiting for the entire codebase to be reviewed, the project was introduced in the staging branch and development occurred there. This was following the precedent set by confidential-containers/td-shim .
We think that now is the appropriate time to move move development to main. There are a few reasons. First, simple-kbs is now feature complete. Second, simple-kbs has decent testing coverage. Third, https://github.com/kata-containers/kata-containers/pull/4270 will merge the other end of the protocol into Kata CCv0. There is still more development to be done, but it seems reasonable to move things to main.
Ideally the code can be thoroughly reviewed before the merge, with some issues being fixed immediately and others being postponed until after the merge. Of course if people were hesitant to review the code originally, they might also be hesitant to review it now (and there is now a bit more of it too). Hopefully this won't become a blocker on future development.
This PR contains all of the commits we have made to staging. Ideally we could break this down into smaller pieces, but it's not clear how to do this without a lot of overhead. The commit history is fairly clear and there really isn't that much code. That said, if you have any suggestions about how we might split things up, I would be very interested.
The more we put off merging the more code we will have, so it's better that we get it over with now. I'm not sure I'd recommend this whole development in staging branch strategy in the future either.
simple-kbswas originally developed internally. As such, a somewhat significant amount of code was available when the project was first moved to this repository. In order to continue active development without waiting for the entire codebase to be reviewed, the project was introduced in the staging branch and development occurred there. This was following the precedent set by confidential-containers/td-shim .We think that now is the appropriate time to move move development to main. There are a few reasons. First,
simple-kbsis now feature complete. Second,simple-kbshas decent testing coverage. Third, https://github.com/kata-containers/kata-containers/pull/4270 will merge the other end of the protocol into Kata CCv0. There is still more development to be done, but it seems reasonable to move things to main.Ideally the code can be thoroughly reviewed before the merge, with some issues being fixed immediately and others being postponed until after the merge. Of course if people were hesitant to review the code originally, they might also be hesitant to review it now (and there is now a bit more of it too). Hopefully this won't become a blocker on future development.
This PR contains all of the commits we have made to staging. Ideally we could break this down into smaller pieces, but it's not clear how to do this without a lot of overhead. The commit history is fairly clear and there really isn't that much code. That said, if you have any suggestions about how we might split things up, I would be very interested.
The more we put off merging the more code we will have, so it's better that we get it over with now. I'm not sure I'd recommend this whole development in staging branch strategy in the future either.
@dubek