Closed alpe closed 2 years ago
I left a low-priority follow up issue here: https://github.com/confio/tgrade/issues/399 And adjusted the parameters to provide desired results.
This is good to go for mainnet. We can extend later, especially if a new network will use this implementation.
Merging #395 (782c4e9) into main (8a6618d) will increase coverage by
0.14%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 57.43% 57.57% +0.14%
==========================================
Files 73 73
Lines 5544 5563 +19
==========================================
+ Hits 3184 3203 +19
Misses 2043 2043
Partials 317 317
Impacted Files | Coverage Δ | |
---|---|---|
x/poe/bootstrap.go | 64.56% <100.00%> (ø) |
|
x/poe/types/genesis.go | 94.37% <100.00%> (+0.37%) |
:arrow_up: |
Follow up on #386
~~Note to reviewer: tests do fail with my second commit. The sigmoid valued used in tests and config before were not equal. I need help to adjust them to the expected values~~
Reverted the changes to the test after discussing with @maurolacy