search

confluentinc / kafka-connect-bigquery

A Kafka Connect BigQuery sink connector
Apache License 2.0
3 stars 2 forks source link

Support n:1 to topic2TableMap (topic:table) #361

Closed jx2lee closed 1 year ago

jx2lee commented 1 year ago

like snowflow sink connector, it would be nice to have this. https://github.com/snowflakedb/snowflake-kafka-connector/pull/459

I haven't written an integration test code because integration tests don't work well locally. Do I need to?

cla-assistant[bot] commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jx2lee commented 1 year ago

@b-goyal thanks for check PR!

b-goyal commented 1 year ago

@jx2lee - build passes, good to merge. Could you please rebase the branch to 2.5.x (instead of master) ?

jx2lee commented 1 year ago

@b-goyal success to chnage root branch (master to 2.5.x) check this out, please/

b-goyal commented 1 year ago

Modified the PR base branch to 2.5.x as well. @jx2lee

jx2lee commented 1 year ago

thanks, @b-goyal

b-goyal commented 1 year ago

Jenkins build is failing, re-tried a few times. I will take a look into it and approve the PR once this build is fixed.

jx2lee commented 1 year ago

okay, i got it. thanks for pr-review

jx2lee commented 1 year ago

@b-goyal could you tell me how long failed build will be fixed?

b-goyal commented 1 year ago

Hey @jx2lee, was out for a few days. I will check and get back on this by end of next week.