confluentinc / kafka-connect-datagen

Connector that generates data for demos
Apache License 2.0
20 stars 87 forks source link

Make inventory and product more useable: modified data set #106

Closed ybyzek closed 2 years ago

ybyzek commented 2 years ago

Problem

The goal of this PR is to make the current inventory and product datasets more usable, because they are current just monotonically increasing and not useful

Current use case: retrofit https://developer.confluent.io/tutorials/inventory/confluent.html to use Datagen

Note: the changes are not backwards compatible but because the current datasets are so unusable, this breaking change is worthwhile.

Solution

Test Strategy

Testing done:

This was validated with the following:

inventory connector config: config/connector_inventory.config product connector config: config/connector_product.config ksqlDB query: tests/inventory-product.sql

Release Plan

shaikzakiriitm commented 2 years ago

Schema changes for INVENTORY look backward compatible however, in case of PRODUCT, change from long to int, does it make a backward incompatible change? Just want to make sure it doesn't make it backward incompatible here.

shaikzakiriitm commented 2 years ago

Hi @ybyzek Description mentions the changes as backward incompatible. Can you please share how this change is making it backward incompatible? Probably I'm missing something!

Rest, the pr looks good to me. Thanks!

ybyzek commented 2 years ago

Hi @ybyzek Description mentions the changes as backward incompatible. Can you please share how this change is making it backward incompatible? Probably I'm missing something!

It is mostly compatible in the sense that the connector can still be run the same way and it still produces the same field names. However, it is arguably incompatible because the values generated are now different, but perhaps incompatible is an overkill way to describe this change. @bbejeck @davetroiano WDYT?

ybyzek commented 2 years ago

Not planning to proceed with this PR, closing.