search

conformal / gotk3

Go bindings for GTK3
ISC License
470 stars 81 forks source link

Added basic TextView support (just constructor so far). #8

Closed weberc2 closed 10 years ago

weberc2 commented 11 years ago

Please leave feedback if you have any. I'm new to git and CGo.

jrick commented 11 years ago

What you have here looks like a good start. Implement some more TextView functions and I can merge it in.

weberc2 commented 11 years ago

Please review these changes carefully. I'm not a low-level programmer by nature. I'm learning. You may want to pay careful attention to TextBuffer.GetBounds()

weberc2 commented 10 years ago

This should be ready for review. I pulled in your upstream changes, which messed up the github diff for the whole pull request, so you'll have to diff manually. Sorry for the inconvenience. Let me know what I can do to improve this.

Thanks.

jrick commented 10 years ago

I merged this into Conformal's branch in commit 70587381a0081d13d74ad753f887919856f162ed. Thanks!