conjure-cp / conjure-oxide

Mozilla Public License 2.0
9 stars 16 forks source link

Fix multiple applicable rules for Minion #405

Closed niklasdewally closed 2 weeks ago

niklasdewally commented 4 weeks ago

Sometimes, there are multiple applicable rules in tests. In #401 , we add a check for this, which causes test failures.

We only should have one representation of the model at the moment (per solver, at-least), and I am writing my Minion rules with a set order of operations in mind. These failing rules likely either have a bad priority, or don't have strict enough preconditions.

ozgurakgun commented 4 weeks ago

Fixing with preconditions, i.e. independently of rule priority, is better than relying on priorities. As much as possible/sensible.

On Fri, Nov 1, 2024 at 5:56 PM Niklas Dewally @.***> wrote:

Sometimes, there are multiple applicable rules in tests. In #393 https://github.com/conjure-cp/conjure-oxide/pull/393 , we add a check for this, which causes test failures.

We only should have one representation of the model at the moment (per solver, at-least), and I am writing my Minion rules with a set order of operations in mind. These failing rules likely either have a bad priority, or don't have strict enough preconditions.

— Reply to this email directly, view it on GitHub https://github.com/conjure-cp/conjure-oxide/issues/405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNEUVR3VJNDM2NAMSUSEDZ6O6GJAVCNFSM6AAAAABRAWJYCOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDSNJYGA2DONQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Özgür Akgün

niklasdewally commented 2 weeks ago

Closed by #411