connormanning / entwine

Entwine - point cloud organization for massive datasets
https://entwine.io
Other
451 stars 128 forks source link

Fixing bug in case vlrs are not present #206

Closed nicolas-chaulet closed 5 years ago

nicolas-chaulet commented 5 years ago

When vlrs are not present in an las file, then the rangeHeaders are headerSize-(headerSize-1) which is not a valid range request it appears. I am not sure what exactly happens but I suspects that it downloads the whole file which is not ideal. I added a chec k to grab those extra headers only if they are present

connormanning commented 5 years ago

Nice catch - I don't think I've ever actually run into such a file in the wild.

nicolas-chaulet commented 5 years ago

Interesting. I have actually plenty of them, sending one in an email. They are all generated by Pdal.