connormanning / entwine

Entwine - point cloud organization for massive datasets
https://entwine.io
Other
451 stars 128 forks source link

Missing empty srs #268

Closed kcotar closed 1 year ago

kcotar commented 2 years ago

When building data without any projection info, version 2.1 produced an empty srs entry in ept.json. With version 2.2 this field is not present anymore, and data can not be visualised with Potree without manually adding the srs field.

defaultbranch commented 2 years ago

@kcotar, I observed a similar behavior, but I don't consider it a bug of entwine. For me, the current behavior (to break Potree when no reference data is set) is actually helpful, it prevents mixing up global-vs-local coordinate systems.

Reproduction (just for clarification)

Required: some $WORKDIR folder, containing some $LASFILE, with no embedded information on the coordinate system; the following steps try to run entwine build -i $WORKDIR/$LASFILE -o $WORKDIR/output/ in a recent container image:

Outcome

Potree logs an error to the Javascript console, reporting the missing srs info.

Possible solution (works for me)

Run entwine … --srs "EPSG:2056"… (code for Switzerland, use the EPSG code appropriate for your data); this helps to label the data's reference system and to avoid problems when working with multiple reference systems.

connormanning commented 1 year ago

Yeah, agree that this is out of scope for Entwine and is a one-line fix upstream in Potree.