constabulary / gb

gb, the project based build tool for Go
https://getgb.io/
MIT License
2.15k stars 148 forks source link

gb: add testing/internal/testdeps as an extra dependency #711

Closed davecheney closed 7 years ago

davecheney commented 7 years ago

Fixes #707

Go 1.8 split out some parts of the testing package into testing/internal/testdeps. This is an implicit dependency that needs to be part of the dep graph to ensure if the runtime is stale, eg, when cross compiling, it is rebuilt.

codecov-io commented 7 years ago

Codecov Report

Merging #711 into master will decrease coverage by 0.32%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage    52.9%   52.58%   -0.33%     
==========================================
  Files          42       42              
  Lines        3151     3155       +4     
==========================================
- Hits         1667     1659       -8     
- Misses       1341     1351      +10     
- Partials      143      145       +2
Impacted Files Coverage Δ
build.go 77.92% <0%> (-7.42%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a742b9...318e158. Read the comment docs.