search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

go.mod: github.com/containerd/containerd v1.7.7, containerd/nri v0.4.0 #597

Closed thaJeztah closed 5 months ago

thaJeztah commented 5 months ago

Update to the first release of containerd to alias the log package to the new containerd/log module.

This update of the containerd module also comes with an updated version of github.com/containerd/nr, which has some breaking changes in the interface definitions.

the optimizer-nri-plugin and prefetchfilees-nri-pugin pacakges had to be updated due to containerd/nri@9d86150 changing the interface to require a context to be passed.

Full diffs:

thaJeztah commented 5 months ago

Ah, Linter doesn't like this, because this version of containerd already deprecated the log package;

 Error: SA1019: log.L is deprecated: use [log.L].  (staticcheck)
  Error: SA1019: log.L is deprecated: use [log.L].  (staticcheck)
  Error: SA1019: log.L is deprecated: use [log.L].  (staticcheck)
  Error: SA1019: log.G is deprecated: use [log.G].  (staticcheck)
  Error: SA1019: log.G is deprecated: use [log.G].  (staticcheck)
  Error: SA1019: log.G is deprecated: use [log.G].  (staticcheck)
  Error: SA1019: log.RFC3339NanoFixed is deprecated: use [log.RFC3339NanoFixed].  (staticcheck)
  Error: SA1019: log.WithLogger is deprecated: use [log.WithLogger].  (staticcheck)

Let me see if I can find an intermediate version with only the nri update, then do another bump in https://github.com/containerd/nydus-snapshotter/pull/598

(I thought I'd split it in 2 PRs for easier review)

thaJeztah commented 5 months ago

Ah, nope; looks like both were in v1.7.7; https://github.com/containerd/containerd/pull/9099

I'll combine both PRs after all then

thaJeztah commented 5 months ago