containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

CI fix, part II: kube #607

Closed apostasie closed 3 months ago

apostasie commented 4 months ago

This is fixing the recent kube testing bustage.

NOTE that this PR is on-top of #606 as I needed a working CI environment as a starting point to debug. We can either merge this and close 606, or merge 606 first, then I will rebase here.

As far as I can tell, the issues with kube were:

  1. fallout of #603 that did miss a bunch of strings
  2. containerd-nydus-grpc was built dynamically on the host, but copied into the kind control plane container that could (and does) have a different libc
  3. the rig was tightly coupled with github actions, making it really hard to test locally. Specifically, we depended upon engineerd/setup-kind which has been untouched in two years and is using deprecated features from github action anyhow

What this PR does (in commit "Fix kube test bustage"):

CI is now green and both PRs are ready to review.

Hope this is helpful.

apostasie commented 3 months ago

@imeoer going to rebase this ASAP so that we can consider just the Kube fixes

apostasie commented 3 months ago

@imeoer rebased - one commit left - CI is green.

I just added a bunch of inline comments to facilitate review. PTAL at your convenience and LMK if you want anything changed in this.

Thanks for your help!